fix(striker-ui): only send changed properties when edit file

striker-ui/components/Files/FileEditForm.tsx

@@ -1,3 +1,4 @@
+import { AxiosResponse } from 'axios';
 import {
   FormEventHandler,
   MouseEventHandler,
@@ -17,6 +18,16 @@ import Spinner from '../Spinner';
 import fetchJSON from '../../lib/fetchers/fetchJSON';
 import mainAxiosInstance from '../../lib/singletons/mainAxiosInstance';
 
+type ReducedFileLocation = Partial<
+  Pick<FileLocation, 'fileLocationUUID' | 'isFileLocationActive'>
+>;
+
+type EditRequestContent = Partial<
+  Pick<FileDetailMetadata, 'fileName' | 'fileType' | 'fileUUID'>
+> & {
+  fileLocations: ReducedFileLocation[];
+};
+
 type FileEditProps = {
   filesOverview: FileOverviewMetadata[];
   onEditFilesComplete?: () => void;
@@ -40,6 +51,9 @@ const FileEditForm = (
     onPurgeFilesComplete,
   }: FileEditProps = FILE_EDIT_FORM_DEFAULT_PROPS as FileEditProps,
 ): JSX.Element => {
+  const [editRequestContents, setEditRequestContents] = useState<
+    EditRequestContent[]
+  >([]);
   const [filesToEdit, setFilesToEdit] = useState<FileToEdit[]>([]);
   const [isLoadingFilesToEdit, setIsLoadingFilesToEdit] =
     useState<boolean>(false);
@@ -57,14 +71,14 @@ const FileEditForm = (
   const generateFileInfoChangeHandler =
     (fileIndex: number): FileInfoChangeHandler =>
     (inputValues, { fileLocationIndex } = {}) => {
-      if (fileLocationIndex) {
+      if (fileLocationIndex !== undefined) {
-        filesToEdit[fileIndex].fileLocations[fileLocationIndex] = {
+        editRequestContents[fileIndex].fileLocations[fileLocationIndex] = {
-          ...filesToEdit[fileIndex].fileLocations[fileLocationIndex],
+          ...editRequestContents[fileIndex].fileLocations[fileLocationIndex],
           ...inputValues,
         };
       } else {
-        filesToEdit[fileIndex] = {
+        editRequestContents[fileIndex] = {
-          ...filesToEdit[fileIndex],
+          ...editRequestContents[fileIndex],
           ...inputValues,
         };
       }
@@ -75,25 +89,62 @@ const FileEditForm = (
 
     setIsLoadingFilesToEdit(true);
 
-    const editPromises = filesToEdit.map(
+    const editPromises = editRequestContents.reduce<Promise<AxiosResponse>[]>(
-      ({ fileLocations, fileName, fileType, fileUUID }) =>
+      (
-        mainAxiosInstance.put(
+        reducedEditPromises,
-          `/files/${fileUUID}`,
+        { fileLocations, fileName, fileType, fileUUID },
-          JSON.stringify({
+      ) => {
-            fileName,
+        const editRequestContent: Partial<EditRequestContent> = {};
-            fileType,
+
-            fileLocations: fileLocations.map(
+        if (fileName !== undefined) {
-              ({ fileLocationUUID, isFileLocationActive }) => ({
+          editRequestContent.fileName = fileName;
+        }
+
+        if (fileType !== undefined) {
+          editRequestContent.fileType = fileType;
+        }
+
+        const changedFileLocations = fileLocations.reduce<
+          ReducedFileLocation[]
+        >(
+          (
+            reducedFileLocations,
+            { fileLocationUUID, isFileLocationActive },
+          ) => {
+            if (isFileLocationActive !== undefined) {
+              reducedFileLocations.push({
                 fileLocationUUID,
                 isFileLocationActive,
-              }),
+              });
-            ),
+            }
-          }),
+
+            return reducedFileLocations;
+          },
+          [],
+        );
+
+        if (changedFileLocations.length > 0) {
+          editRequestContent.fileLocations = changedFileLocations;
+        }
+
+        const stringEditFileRequestContent = JSON.stringify(editRequestContent);
+
+        if (stringEditFileRequestContent !== '{}') {
+          reducedEditPromises.push(
+            mainAxiosInstance.put(
+              `/files/${fileUUID}`,
+              stringEditFileRequestContent,
               {
                 headers: { 'Content-Type': 'application/json' },
               },
             ),
           );
+        }
+
+        return reducedEditPromises;
+      },
+      [],
+    );
 
     Promise.all(editPromises)
       .then(() => {
@@ -180,6 +231,27 @@ const FileEditForm = (
       }),
     ).then((fetchedFilesDetail) => {
       setFilesToEdit(fetchedFilesDetail);
+
+      const initialEditRequestContents: EditRequestContent[] = [];
+
+      for (
+        let fileIndex = 0;
+        fileIndex < fetchedFilesDetail.length;
+        fileIndex += 1
+      ) {
+        const fetchedFileDetail = fetchedFilesDetail[fileIndex];
+        initialEditRequestContents.push({
+          fileUUID: fetchedFileDetail.fileUUID,
+          fileLocations: fetchedFileDetail.fileLocations.map(
+            ({ fileLocationUUID }) => ({
+              fileLocationUUID,
+            }),
+          ),
+        });
+      }
+
+      setEditRequestContents(initialEditRequestContents);
+
       setIsLoadingFilesToEdit(false);
     });
   }, [filesOverview]);

striker-ui/components/Files/FileInfo.tsx

@@ -93,9 +93,11 @@ const FileInfo = (
           disabled={isReadonly}
           id={fileNameElementId}
           label={fileNameElementLabel}
-          onChange={({ target: { value } }) =>
+          onChange={({ target: { value } }) => {
-            onChange?.call(null, { fileName: value })
+            onChange?.call(null, {
-          }
+              fileName: value === fileName ? undefined : value,
+            });
+          }}
         />
       </FormControl>
       {fileType && (
@@ -108,9 +110,11 @@ const FileInfo = (
             disabled={isReadonly}
             id={fileTypeElementId}
             input={<OutlinedInput label={fileTypeElementLabel} />}
-            onChange={({ target: { value } }) =>
+            onChange={({ target: { value } }) => {
-              onChange?.call(null, { fileType: value as FileType })
+              onChange?.call(null, {
-            }
+                fileType: value === fileType ? undefined : (value as FileType),
+              });
+            }}
           >
             {UPLOAD_FILE_TYPES_ARRAY.map(
               ([fileTypeKey, [, fileTypeDisplayString]]) => {
@@ -136,13 +140,16 @@ const FileInfo = (
                 defaultChecked={isFileLocationActive}
                 disabled={isReadonly}
                 icon={<SyncDisabledIcon />}
-                onChange={({ target: { checked } }) =>
+                onChange={({ target: { checked } }) => {
                   onChange?.call(
                     null,
-                    { isFileLocationActive: checked },
+                    {
+                      isFileLocationActive:
+                        checked === isFileLocationActive ? undefined : checked,
+                    },
                     { fileLocationIndex },
-                  )
+                  );
-                }
+                }}
               />
             }
             key={anvilUUID}