From 1e159f548eebb48081fbf348c4e86d77695c6dcc Mon Sep 17 00:00:00 2001 From: Digimer Date: Fri, 16 Jul 2021 11:13:48 -0400 Subject: [PATCH] Added a couple notes for later dev. Signed-off-by: Digimer --- Anvil/Tools/Cluster.pm | 6 ++++++ tools/anvil-provision-server | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Anvil/Tools/Cluster.pm b/Anvil/Tools/Cluster.pm index 617731f2..b7c8e965 100644 --- a/Anvil/Tools/Cluster.pm +++ b/Anvil/Tools/Cluster.pm @@ -2483,6 +2483,10 @@ sub manage_fence_delay prefer => $prefer, }}); + ### NOTE: We don't really need this anymore, though there is one reason we might (to be decided later); + ### See: https://clusterlabs.org/pacemaker/doc/2.1/Pacemaker_Explained/singlehtml/index.html#cluster-options + ### - priority-fencing-delay + # Are we a node? my $host_type = $anvil->Get->host_type({debug => $debug}); $anvil->Log->variables({source => $THIS_FILE, line => __LINE__, level => $debug, list => { host_type => $host_type }}); @@ -2552,6 +2556,8 @@ sub manage_fence_delay } } + ### TODO: We don't need to specify the full argument list, we only need to set 'delay=""' to delete + ### the delay, and 'delay="15"' to add it. my $preferred_node = ""; foreach my $node_name (sort {$a cmp $b} keys %{$anvil->data->{fence_method}}) { diff --git a/tools/anvil-provision-server b/tools/anvil-provision-server index 840aa533..d7866471 100755 --- a/tools/anvil-provision-server +++ b/tools/anvil-provision-server @@ -428,8 +428,10 @@ sub provision_server say_memory => $say_memory, }}); - ### TODO: Support user-selected IFN. For now, we hard-code it to 'ifn_bridge1' - ### Support disk images (ie: sysprep) via '--import'. The device used for booting is the first device specified via "--disk" + ### TODO: Support user-selected IFN. For now, we hard-code it to 'ifn_bridge1' Also allow a MAC to be + ### set with '--network ifn1_bridge1[:mac],ifn2_bridge1[:mac]...'. + ### Support disk images (ie: sysprep) via '--import'. The device used for booting is the first + ### device specified via "--disk" ### Consider support for TPM, RNG and watchdog devices my $shell_call = $anvil->data->{path}{exe}{'virt-install'}." --connect qemu:///system \\\n"; $shell_call .= "--name ".$server." \\\n";